search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.94k stars 637 forks source link

Test Coverage #426

Open acemac opened 6 years ago

acemac commented 6 years ago

Is your feature request related to a problem? Please describe. There is currently ~25% code coverage from unit tests in this library. There is no tests for the interactjs behaviour, scrolling with the mouse etc.

Describe the solution you'd like Better code coverage of the core component loops. UI automation tests in common browsers for the mouse/touch interactions

Describe alternatives you've considered Not testing

Additional context On our closed source project, we test this component's behaviour pretty well using Test Cafe as a devDependency. I will talk about getting tests released to the community if we are happy to include it.

Ilaiwi commented 6 years ago

hi @acemac thank you for this! I agree this is really needed for this project and crucial for development and stability since there is a lot of code that has not been documented correctly and is very hard to understand like the stackingItems code. I created #431 as a first initiative to increase unit testing and in #391 I aim to do unit tests for the headers which will increase the percentage of test coverage. As for doing e2e testing for this library, I would rather to spend the resources to increase unit testing for this lib first. However, e2e addition is welcome but as far as this library priority would be unit testing. Please if you decided to proceed with e2e testing please consider doing it in two steps: the first is getting the dev tools to work with adding simple tests then lets work on getting more e2e tests

Ilaiwi commented 6 years ago

@acemac I would appreciate it if you can take a look at #432 .