search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.92k stars 616 forks source link

Build creates strange folder structure lib/lib #574

Open tobiasbueschel opened 5 years ago

tobiasbueschel commented 5 years ago

Is your feature request related to a problem? Please describe. I noticed that when installing this module, react-calendar-timeline has the following folder structure: image

Describe the solution you'd like I think it would be great if we could change the build command to write to a dist folder as it's arguably more conventional. https://github.com/namespace-ee/react-calendar-timeline/blob/b94cd37e196ca64b59079dbea62d9b795ef41221/package.json#L9

Happy to submit a PR for this in the next days!

Ilaiwi commented 5 years ago

that would help thanks

trevdor commented 5 years ago

Hey @tobiasbueschel and @Ilaiwi, mind seeing if the above PR would do what you are thinking of?

I agree the lib/lib output is a little odd. My only question is whether there's much to be gained by shipping the breaking change. I suppose it isn't a big deal since it's simple enough to update references to the old directory to point to the new one.