search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.94k stars 634 forks source link

className is not applied to top-level Timeline element #739

Open hkmarques opened 4 years ago

hkmarques commented 4 years ago

First of all, thank you for all of your work on React Calendar Timeline! It is a fantastic piece of work and even in the unfortunate event that I'm not able to use it as it is, it will provide me and my colleagues with a solid head start!

Maybe I'm just forgetting something silly, but I've tried setting the className prop to no effect, despite it being documented and there being an old PR https://github.com/namespace-ee/react-calendar-timeline/pull/683 that supposedly added just that.

Describe the bug The className prop apparently does not affect the root Timeline element (or any elements that I could see), contrary to what is documented at https://github.com/namespace-ee/react-calendar-timeline#classname

To Reproduce Codebox sample trying to set a custom className: https://codesandbox.io/s/timeline-demo-sticky-header-x5gqc?file=/CustomTimeline.jsx

Expected behavior The additional class name(s) passed to the prop would be added to the root div element.

Screenshots (nothing happens to the root div)

Screen Shot 2020-04-21 at 01 52 45

Library Version 0.26.7

Desktop (please complete the following information):

trevdor commented 4 years ago

:EDIT: My mistake -- looks like 0.26.7 was tagged before the commit that added the className prop to <Timeline/>. That's why it's not working, @hkmarques. See #682, which is labeled pending-release.

hkmarques commented 4 years ago

:EDIT: My mistake -- looks like 0.26.7 was tagged before the commit that added the className prop to <Timeline/>. That's why it's not working, @hkmarques. See #682, which is labeled pending-release.

Thanks @trevdor. I did see the PR with the label, but seeing the comment about it being released "later today" on Feb 17th I thought it had been already released, but then reverted back for some reason. Looking forward to the release, thanks for the reply.