search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.91k stars 613 forks source link

fixed timeline onScroll handler min and max value #834

Open StoikovOleh opened 2 years ago

StoikovOleh commented 2 years ago

addressed Issue: #805, and probably more.

Overview of PR

fixed scroll of the timeline to prevent scrolling behind visibleTimeStart and visibleTimeEnd min and max values

Ilaiwi commented 2 years ago

@StoikovOleh I tried to run this with the code for #805 but it didn't work. Also, do you maybe have a more specific example of a bug that this PR would eliminate?

StoikovOleh commented 2 years ago

@StoikovOleh I tried to run this with the code for #805 but it didn't work. Also, do you maybe have a more specific example of a bug that this PR would eliminate?

@Ilaiwi Yo are able scroll to the next and previous day, despite the fact visibleTimeStart and visibleTimeEnd is alway the start and the end of the one day

Ilaiwi commented 2 years ago

@StoikovOleh yes using trackpads only.

StoikovOleh commented 2 years ago

@Ilaiwi, yes, it causing bugs on our project, because we didn't suppose that we could scroll futher then min or max value, you can message me in the telegram @OStoikov

StoikovOleh commented 2 years ago

I saw some code in your lib which was suppose to fix it but it was removed in the newer version

Ilaiwi commented 2 years ago

@StoikovOleh what method were you using to scroll? Was it programmatically or via trackpad/mouse?

StoikovOleh commented 2 years ago

@StoikovOleh what method were you using to scroll? Was it programmatically or via trackpad/mouse?

trackpad

StoikovOleh commented 1 year ago

@Ilaiwi ?