search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.91k stars 613 forks source link

fix: On time change called (no before) on item drag #893

Open DanielDerma opened 1 year ago

DanielDerma commented 1 year ago

838

Link issue.

I think that is a misunderstanding with the bug, why it should have been called onTimeChange when I drag i item?

docs:

onTimeChange(visibleTimeStart, visibleTimeEnd, updateScrollCanvas, unit)

A function that's called when the user tries to scroll. Call the passed updateScrollCanvas(start, end) with the updated visibleTimeStart and visibleTimeEnd (as unix timestamps in milliseconds) to change the scroll behavior, for example to limit scrolling.

Ilaiwi commented 1 year ago

@florianbepunkt @MertHaddad can you help verify this PR please