search

namespace-ee / react-calendar-timeline

A modern and responsive react timeline component.
MIT License
1.93k stars 625 forks source link

FIx redraw mechanism to be based on buffer and not viewport #913

Closed LudvigHz closed 2 days ago

LudvigHz commented 1 year ago

Also updates node-sass to latest version to support newer node versions.

The README states that the canvas should redraw when there is 1/2 of the buffer left off-screen on any side of the viewport. However, the code calculates the redraw based on 1/2 of the viewport and not the buffer. This PR fixes this. This means that for buffers larger than the default, we re-render way less often, providing for better performance with large timelines. As it is now, for many tasks (~1000) the canvas continuously re-renders when scrolling, and the rendering cannot keep up with scrolling, forcing the items to appear as they jump around a lot.

I don't know if this repo is actively maintained, but we will use our own fork (NPM) as long as this PR is open and the repo appears unmaintained.

LudvigHz commented 2 days ago

This is obviously not maintained, so I'm going ahead and closing this :)