namib-project / dcaf-rs

Implementation of the ACE-OAuth framework.
4 stars 1 forks source link

ci: update grcov to latest stable version #27

Closed pulsastrix closed 1 week ago

pulsastrix commented 1 week ago

The new stable release of grcov fixes the compilation issue related to the time crate, which we previously worked around by pulling in the branch from mozilla/grcov#1191.

Therefore, our previous workaround is no longer necessary, and we can use the stable version again.

falko17 commented 1 week ago

PR itself is good to go, but for some reason the test_coverage CI is failing now.

pulsastrix commented 1 week ago

Apparently, the -Zprofile unstable flag has been removed, see rust-lang/rust#131829 and the feature's tracking issue rust-lang/rust#42524.

The (stable) replacement seems to be the instrument-coverage flag, I'll have a look at the required changes to get our pipeline working again using this flag.

coveralls commented 1 week ago

Coverage Status

coverage: 86.555% (+1.3%) from 85.242% when pulling d2b3d706be1ac5370da493b610b8a08186386854 on ci_update_grcov into 3832486412e311bd2acd0f46fde0017068f4d215 on main.

pulsastrix commented 1 week ago

The pipeline is now switched over to using the newer (and stable) -C instrument-coverage flag, which enables source-based coverage reports.

For future reference, see: