search

namib-project / libcoap-rs

Rust bindings to and wrapper around the libcoap C library
BSD 2-Clause "Simplified" License
6 stars 1 forks source link

Implement support for CoAP over tcp #12

Closed petardimitrijevic closed 1 year ago

petardimitrijevic commented 1 year ago

This pull request implements CoAP over TCP.

pulsastrix commented 1 year ago

Thanks for the PR! LGTM aside from what @falko17 already mentioned.

Regarding the test failures: It seems that rust-lang/rust#109044 is the cause. I have pushed a commit that switches the test jobs over to nightly to main, so rebasing the PR branch should fix the checks.

petardimitrijevic commented 1 year ago

I have fixed the comments. The changes are pushed.

Thanks for the PR! LGTM aside from what @falko17 already mentioned.

Glad that I could help.

petardimitrijevic commented 1 year ago

I've rebased the branch on main, so that it includes @pulsastrix switch to nightly toolchain. The pipeline should pass with this commit.

JKRhb commented 1 year ago

@pulsastrix @falko17 I guess this PR should now be ready to be merged, right? Or does the coverage job need to be fixed first?

pulsastrix commented 1 year ago

@JKRhb the coverage job failure is due to the fact that this PR comes from a fork, which causes the CI pipeline to have insufficient permissions to create comments in the main repository. Will merge now.