search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
2.09k stars 127 forks source link

[FEATURE REQUEST] Embed lrc into track file. #138

Open z9xx7o0 opened 7 months ago

z9xx7o0 commented 7 months ago

Can you add the feature to embed the lyrics that namida finds into the track? Lately, in android 14, accessing the android/data folder is not that good, we used to be able to use any file manager, but now the only way is through adb or the stock files app which is really hard to work with.

MSOB7YY commented 7 months ago

why not copy lrc text and edit tags manually? im against auto editing tags honestly and there is no good place for such a button, is there?

z9xx7o0 commented 7 months ago

Well, it's not auto. The person gets to see the lyrics before manually clicking an embed button. It could be placed next to the copy button or inside the tag editor.

Which, by the way, seems to have some problems. Firstly, if you add/change comment/lyrics and save, if you open the tag editor again, they appear to be empty, and if you actually want to have them empty then you have to add then delete a character for a change to be detected, also if you manualy enter unsynced lyrics it treats them as synced and nothing is displayed. Then, when i try to select the cache, it doesn't allow it until I clear the ones from the tag editor.