namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
2.09k stars 127 forks source link

[Feature request] Support for Android tablets #142

Open farzana840 opened 6 months ago

farzana840 commented 6 months ago

Current everything on tablets looks and works great on tablet except the main audio player. It's not optimised. The album art is too big and covers the particle effect, also the animated thumbnail is hardly noticeable. A bit of optimisation and it'll be fixed. The app, otherwise is really great. Screenshot_20240312_171156

farzana840 commented 6 months ago

Also, this needs a bit fixing too SmartSelect_20240312_205719

MSOB7YY commented 6 months ago

hello, i understand that tablet ui is not the best, i don't really plan on adding/tweaking specific ui parts based on dimension scaling (somehow like YouTube app does). B U T, most of these stuff u mentioned are manually customizable:

lemme know if u have further issues!

farzana840 commented 6 months ago

Thanks, those tips were very helpful:)

I have 4 more issues 1) while importing my playlist only 100 to 103 of the songs in the playlist are actually imported Screenshot_20240313_014300_Chrome My playlist originally contains 237 songs but they aren't imported

2) after downloading the videoes from YouTube, the videos don't show up in my home tab, only if I downloaded the audio version do they get imported in the offline library. I love watching AMVs but watching then without the mv kinda defeats the point 😭

3) I may be nitpicking but the videos from YouTube take quite a while to load even at low resolution and stable internet. Is there any workaround?

4) if I go to my online playlist and click to play a video, it doesn't respond, like—no reaction to touches at all. I have to manually long press to play each vid. Not a big bug but it's irritating :(

https://github.com/namidaco/namida/assets/68196826/ced86406-d238-43fc-93b2-cd72fba27f42

Arigato in advance!

MSOB7YY commented 6 months ago

@farzana840 sorry for late reply pookie

  1. c c- can u send the playlists directory takeout? it might be some sort of shakalaka gotta confirm
  2. yisss bcz offline library is music onlyy, i really need to add "caching" button similar to download.. one way to workaround this is to download audio only and then when u play it normally it will fetch the video to app cache. do you actually want an external video+audio file like to play outside namida?
  3. i have no idea, it surely be youtube api throttling but i suck at network workarounds.
  4. uh... have u tried latest snapshot? i think i fixed smth similar a while ago

no need to thanks domo domoo~ (fixed nothing)

farzana840 commented 6 months ago

Sorry for the late reply from my side too. Tehee ><

2) I don't want an offline video player. What I want is ONE app for all my music needs. A solution to this would be to integrate the the online video library with the offline one, rather than keeping them as 2 seperate set of spaces. Can be done by..let's say pinning a playlist from YouTube to the offline homepage (it's only imported not downloaed). It stays in the cache and plays in the offline player( u know the animated one ). . This way we can have videos in offline and we won't have to download it.... Also this provdes consitensy in ux as we don't have to switch over to YouTube interface everytime we want to watch mvs. The idea works I guess? Or you can think of something else. Idk lol but plz let me watch my AMVs I can't live without them😭

5) One important feature that namida lacks is save video quality. Let's say you're running out of data and want to watch in 144p. Each time you've to change resolution or deep div into the settings and change it the next time you want to watch in 4k. A "save video quality for this session" would be really good.

Thank you , again. Namida is a great app. Literally has the best UI. Would really love to work on this app's development in the future.(im a web developer) but ive been pretty busy prepping for the world's second hardest entrace examTT) Appreciate your work!

MSOB7YY commented 4 months ago

@farzana840 omgg i completely overlooked this lmao, i hope u did well in ur exam?

  1. so uh.. as stated mixing local library with youtube is not so possible. best way is to disable 'youtube-like miniplayer' from youtube settings & then just watch ur stuff. yeah u still cant mix these with local playlists/history/queue etc but i think u still got to enjoy ur amvs lmao.

  2. yeah this could be very helpful, one way to achieve this maybe is to allow long pressing current quality and then u can set as default for current session or permanently

again, namida is not the great, its you. thank u so much and sorry for late reply lmao