search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
1.51k stars 108 forks source link

[FEATURE REQUEST] Separate lyrics font size in miniplayer and in lrc fullscreen #160

Closed NikunjKhangwal closed 2 months ago

NikunjKhangwal commented 2 months ago

I set a medium text size for lyrics and they appeared fine for a while on thumbnail but then got too small IMG_20240408_105328

NikunjKhangwal commented 2 months ago

Looks like the size is applied directly for both IMG_20240408_105643

MSOB7YY commented 2 months ago

i dont get what exactly is the issue, lyrics font size is bigger in fullscreen and always has been, check https://github.com/namidaco/namida/blob/492813e66a6920371f6ed3e858205e35bce176e5/lib/packages/lyrics_lrc_parsed_view.dart#L177-L178

NikunjKhangwal commented 2 months ago

Then i think it should be same for both

MSOB7YY commented 2 months ago

i don't think so, the focus on lyrics in fullscreen is not the same as when viewed along with other ui elements

NikunjKhangwal commented 2 months ago

As mentioned, the size on thumbnail becomes too small when size in fullscreen isn't big enough. So you have to manually change the size for thumbnail lyrics again if you want to read lyrics there and then need to change it again for fullscreen. That's what i was referring to.

But also i don't use thumbnail lyrics a lot so i guess it's fine. Closing the issue

MSOB7YY commented 2 months ago

hmmm maybe an easier solution is to separate font scale for both expanded lyrics and normal, gonna look into it

MSOB7YY commented 2 months ago

they are now separated in d7afa9a8435f33f3f3507a9b46041236a1e6217e <3

NikunjKhangwal commented 2 months ago

Keep cooking like this

bear-byebear