search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
2.09k stars 127 forks source link

[BUG] lyrics full screen button rarely works #171

Closed aneesh1122 closed 5 months ago

aneesh1122 commented 5 months ago

I touched the lyrics full screen icon

Expected Behavior

It should have expanded easily

Current Behavior

It doesn't expand even after multiple touches

Steps to Reproduce

1.open any song 2.enable lyrics 3.let the lyrics load 4.click the icon which gets the lyrics in full screen

Screenshots

https://github.com/namidaco/namida/assets/45353488/34b6fe92-a452-4ad7-a608-4ccb999a11c7

Logs

Possible Solution

MSOB7YY commented 5 months ago

that's due to artwork being scaled up, this causes the hittest to slightly go out of range, for more info check https://github.com/namidaco/namida/issues/50#issuecomment-1837556192

aneesh1122 commented 5 months ago

that's due to artwork being scaled up, this causes the hittest to slightly go out of range, for more info check #50 (comment)

  • workaround:

    • pinch in/zoom in while synced lyrics is shown to enter fullscreen

  • fix:

    1. enable artwork gestures(scale multiplier) from customization settings
    2. open miniplayer/player ui
    3. pinch out/zoom out to scale artwork down
    4. optional: disable artwork gestures again

The fix is working although pinch in/zoom in only increases the lyrics font, it doesn't let me enter full screen.

MSOB7YY commented 5 months ago

ops ur right lemme check

NikunjKhangwal commented 5 months ago

Since pinching is now used for scaling text size, the fullscreen method isn't possible. I would recommend changing double tap on artwork to enter fullscreen lyrics directly as a workaround for now. We already have extra button to toggle minimized lyrics anyway. In future more shortucts could be added for tapping, double tap and hold as mentioned in #81

aneesh1122 commented 5 months ago

Since pinching is now used for scaling text size, the fullscreen method isn't possible. I would recommend changing double tap on artwork to enter fullscreen lyrics directly as a workaround for now. We already have extra button to toggle minimized lyrics anyway. In future more shortucts could be added for tapping, double tap and hold as mentioned in #81

I actually like how I can have lyrics by double tapping on the album cover.

The fix works great though. At 90% the full screen toggle works perfectly and the cover is barely smaller

NikunjKhangwal commented 5 months ago

Just a workaround for time being, not a permanent solution. I like it too :)

MSOB7YY commented 5 months ago

@NikunjKhangwal @aneesh1122 i agree that double tapping should enter fullscreen, or at least make it optional so the proposal:

NikunjKhangwal commented 5 months ago

How about: Tap: Trigger minimized lyrics (thumbnail lyrics) when they're not active and keep lyrics seeking when lyrics are shown Double Tap: Directly enter fullscreen lyrics Hold: Honestly could be used for anything. Like showing add to playlist pop-up, track info, lyrics options etc. In Musicolet it shows the option to view song artwork freely and replacing artwork with local pictures.

aneesh1122 commented 5 months ago

How about: Tap: Trigger minimized lyrics (thumbnail lyrics) when they're not active and keep lyrics seeking when lyrics are shown Double Tap: Directly enter fullscreen lyrics Hold: Honestly could be used for anything. Like showing add to playlist pop-up, track info, lyrics options etc. In Musicolet it shows the option to view song artwork freely and replacing artwork with local pictures.

how will you close the minilyrics?

NikunjKhangwal commented 5 months ago

how will you close the minilyrics?

By tapping lyrics button on bottom right. Or if something additional can be implemented then another app i use close minilyrics by tapping on the edges of thumbnail and lyrics seeking happen only when tapping in middle.

aneesh1122 commented 5 months ago

how will you close the minilyrics?

By tapping lyrics button on bottom right. Or if something additional can be implemented then another app i use close minilyrics by tapping on the edges of thumbnail and lyrics seeking happen only when tapping in middle.

Well, the touching region is limited enough already. I can only touch the middle one and sometimes above and below the middle one.

The lyrics can be closed by touching an empty area. An area where there are no words.

NikunjKhangwal commented 5 months ago

Well, the touching region is limited enough already. I can only touch the middle one and sometimes above and below the middle one.

The lyrics can be closed by touching an empty area. An area where there are no words.

I'm guessing that would be harder to implement but let see what dev have to say

MSOB7YY commented 5 months ago

i suggest removing lyrics from namida

MSOB7YY commented 4 months ago

yo just allowed entering fullscreen by long pressing. sadly allowing double tap will make normal tap delayed so i gave up on the whole gesture customizing thing, thats for lyrics.

so the current issue has a fix for the button & separate gesture to enter lyrics fullscreen. as for album artwork gestures, there is another request for that at #81

aneesh1122 commented 4 months ago

yo just allowed entering fullscreen by long pressing. sadly allowing double tap will make normal tap delayed so i gave up on the whole gesture customizing thing, thats for lyrics.

so the current issue has a fix for the button & separate gesture to enter lyrics fullscreen. as for album artwork gestures, there is another request for that at #81

Thanks man

NikunjKhangwal commented 4 months ago

Cool. Now i can make my artworks bigger freely. Thanks :)