search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
1.51k stars 108 forks source link

[BUG] Unsupported font in lyrics. #188

Closed Not-James-Bond closed 1 month ago

Not-James-Bond commented 1 month ago

Some LRC lyrics shows some kind of gibberish text (Usually in Hindi songs)

Expected Behavior

Supported readable lyrics should be visible.

Current Behavior

Unsupported font was being shown for few songs.

Steps to Reproduce

  1. Open Namida.
  2. Play music "Khudi by Local Train"
  3. Open Lyrics.
  4. Unsupported font will be shown.

Screenshots

Screenshot_20240512-033358 Screenshot_20240512-033146

Logs

Possible Solution

MSOB7YY commented 1 month ago

this was a font issue and was fixed in an earlier commit. wait the new release or use beta version from github action tab.

bothways this duplicate of https://github.com/namidaco/namida/issues/183

Not-James-Bond commented 1 month ago

this was a font issue and was fixed in an earlier commit. wait the new release or use beta version from github action tab.

bothways this duplicate of #183

Used the latest build from GitHub action workflow: https://github.com/namidaco/namida/actions/runs/9037354238

Still same lyrics issue. Screenshot_20240512-125343 Screenshot_20240512-125401_Namida

.

MSOB7YY commented 1 month ago

😦😦 opss

makes me wonder if i actually fixed it or it was just a dream

Not-James-Bond commented 1 month ago

It seems on few lyrics it's working but on others it's not.

MSOB7YY commented 1 month ago

@Not-James-Bond lyrics issues are all fixed now, gonna push soon and then u may use beta or wait the stable release in a week

Not-James-Bond commented 1 month ago

@MSOB7YY I'll test out the beta and probably will switch to stable later. Thanks. Mind Sharing the PR as well? I'd like to see the changes.

MSOB7YY commented 1 month ago

@Not-James-Bond yeah i just pushed, the fix is done in 47c2351fd76ed7f0cb8153f00536082507b9c019 (was due to default parsing behavior that supposes everything is latin)

other lyrics improvements can be seen for example in bb27bf384003e2c09d24fff0693d4e277a7892c7, 060ccef271b96ab9ce71fb6e0397e01efa2a4b54, 7a63a6e26e68028fa909da9e76d1e5f538c95f4a, f59f23f3325cdc02ab8fecc42a8efb43ba73f75b, 9eecbcb323b9c7b6692a75592dcf86dd1ed6b4eb & dynamic lyrics feature in 8426584fc5d1d21d33a8c8384353fe8c8cbd78bd