namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
2.1k stars 127 forks source link

Feature Request - SponsorBlock Integration #2

Open Red6785 opened 12 months ago

Red6785 commented 12 months ago

yt-dlp has SponsorBlock Integration, and I think an option to enable it in the settings would be an amazing addition. An example of a good use case would be the Calamity OST (https://youtu.be/b8A_FGr4Pjo?si=yBmu2WzkuKzGW8oX), which have a long outro on all the videos.

MSOB7YY commented 12 months ago

this one might be a bit tricky, lots of stuff to take care of but i would like to work on it and see it there one day

btw yt-dlp is not used, so i would deal with a separate api

nice ost btw

Red6785 commented 12 months ago

Oh! I thought you were using yt-dlp, lol. What is being used?

MSOB7YY commented 12 months ago

Newpipe Extractor, same one used for Newpipe

but if i could switch to ytdlp i would, since it supports login unlike newpipe, and i started the project with google-login feature in mind (not soon at all tho)

Red6785 commented 12 months ago

Is there anything blocking you from making the switch?

MSOB7YY commented 12 months ago

yes, the fact that is not actually a switch ;-; its a whole rebuild with a different api, to the level that building from scratch would be easier

also there is no ytdlp api available for dart, so i would have to create mine