Features requests/ bug in the latest app version

hibonox705 commented 1 year ago

Hi,

First of all love your app, it's really nice to have a new looking music and video app. I don't know how hard it's to code it but i have different request and bugs to report.

The first one is that the album artist filter for the artists category doesn't work and show every artists (including the artists that are features on a song) individually, instead of having the artists you have an album from.

~The second one is to have the ability to order tracks of an album (by track number per example). Because when wanting to listen to one they just show up in whatever order.~

~Third one is that in the indexer section, album identifiers. We can't select and save anything but the already pre-selected Name setting.~

UPDATE: with v1.4.8, issue is partially resolved

[x] Album Artists tab, along with search
[x] subpages tracks sorting (b82dce29d98b01f69fba1ea44bee7e131dd44a41) (available since v1.5.4)
[x] album tracks sorting fix
[x] album identifiers saving in settings

MSOB7YY commented 1 year ago

thank you so much, im glad u like my app now for ur requests

i don't quite get what is the expected behavior, are u talking about the sort or the mini search filter? sorting & search filter both works as intended
- featured artists appearing as a separate entry is actually a feature for a more organized library, yet u can still disable from indexer "Extract feat. artists"
  1. previously album tracks were sorted by year or title, i didnt know ppl want their albums to be sorted normally 😶‍🌫️ next release has a fix for this, while exposing all searching alternatives are also requested, i might get working on it sooner
  2. how come? the name is forcely enabled, while u get year and album artist as extra, do you mean u can't select those 2? can u send a video please?

PlumBlossoms13 commented 1 year ago

For point three, you can select 'year' and 'album artist' just fine but the save button doesn't work.

Red6785 commented 1 year ago

You are on v.1.3.0? I had that problem back on 1.0.0, but updating fixed it.

On Sat, Oct 14, 2023, 8:35 PM PlumBlossoms13 @.***> wrote:

For point three, you can select 'year' and 'album artist' just fine but the save button doesn't work.

— Reply to this email directly, view it on GitHub https://github.com/namidaco/namida/issues/21#issuecomment-1763229351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVC4HO3GOYURYYLHKFZXUFLX7M4XVAVCNFSM6AAAAAA6APRTBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGIZDSMZVGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MSOB7YY commented 1 year ago

oh ops, a fix has been pushed 1bcee8b12907f5da036bd71164a8dea8849e15ea apparently i was only activating it if the values are not the same https://github.com/namidaco/namida/blob/a3dcedcc1134ef3aa6c7ba28b6b92d5c7696ffa2/lib/ui/widgets/settings/indexer_settings.dart#L229

hibonox705 commented 1 year ago

thank you so much, im glad u like my app now for ur requests

i don't quite get what is the expected behavior, are u talking about the sort or the mini search filter? sorting & search filter both works as intended

featured artists appearing as a separate entry is actually a feature for a more organized library, yet u can still disable from indexer "Extract feat. artists"

previously album tracks were sorted by year or title, i didnt know ppl want their albums to be sorted normally 😶‍🌫️ next release has a fix for this, while exposing all searching alternatives are also requested, i might get working on it sooner

how come? the name is forcely enabled, while u get year and album artist as extra, do you mean u can't select those 2? can u send a video please?

No problem, thank you for developing such an app

Basically I'm comparing it to other music app where album artist show the artists that you have albums and singles from them. The original artist that released it

And no problem for the other suggestions I will wait for the update when it comes out

MSOB7YY commented 1 year ago

i think i got what u want now

currently the library is organized by every artist, would your issue get resolved by adding a separate Album Artists tab ?

also thanks, the new version is going to be published tomorrow

hibonox705 commented 1 year ago

i think i got what u want now

currently the library is organized by every artist, would your issue get resolved by adding a separate Album Artists tab ?

also thanks, the new version is going to be published tomorrow

Yes if possible of course

Oh nice can't wait to have a look at it

MSOB7YY commented 1 year ago

with v1.4.8, issue is partially resolved

[ ] Album Artists tab, along with search
[x] subpages tracks sorting (b82dce29d98b01f69fba1ea44bee7e131dd44a41) (available since v1.5.4)
[x] album tracks sorting fix
[x] album identifiers saving in settings

hibonox705 commented 1 year ago

with v1.4.8, issue is partially resolved

[ ] Album Artists tab, along with search

[ ] subpages tracks sorting

[x] album tracks sorting fix

[x] album identifiers saving in settings

Yeah just saw the update thanks for doing so. And for the rest no problem don't rush, take your time. It's already mind blowing having a music player like this on GitHub, so no rush for the rest. Take your time and take time for yourself don't burn yourself out

MSOB7YY commented 1 year ago

thank u so much really, i do this because i love it so dw, ty 🌺

MSOB7YY commented 7 months ago

as mentioned, Album Artists and Composers are now available as a dropdown button in artists page, this one took a while ty for being patient

hibonox705 commented 7 months ago

Let's go, thanks for taking time to develop it and implementing it. Just updated the app and it works flawlessly 👌

namidaco / namida