search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
1.48k stars 108 forks source link

[FEATURE REQUEST] Crop youtube topic channels thumbnail #212

Open JayDean5 opened 1 month ago

JayDean5 commented 1 month ago

When downloading the music, in my opinion, not all people don't want rectangle album cover, thank you!

So the album cover won't appear like this

Screenshot_20240527_194208

MSOB7YY commented 1 month ago

cool that's for videos with music only, what about other normal videos? currently we dont do any modifications to the downloaded files, video/audio/image, everything stays to original (with filling metadata ofc)

lovegaoshi commented 1 month ago

this is an annoying issue relevant to android < 13 and samsung. prior to android 13 I believe notif shows squares like the screenshot linked. google introduced the "immersive" notification in android 13 where the album art is shown as landscape, and cropping to suqare looks uglier than the original landscape shape. samsung prior to oneUI6/android 14 always shows a square. in oneUI6 samsung introduced the same immersive notification but 1. samsung crops it themselves too, but annoyingly in the landscape view; and 2. the immersive notification can be swiped up and shows a square, but samsung does not crop that. So for samsung its better to just crop to square.

perhaps more clearly illustrated in the screenshots i posted below: https://github.com/doublesymmetry/KotlinAudio/issues/79

and this applies to all YTM, YT covers (all are landscape) and whatever embedded album covers that are not squares.

MSOB7YY commented 1 month ago

meanwhile here with android 10 style colored notification ☠️