namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
1.48k stars 108 forks source link

[FEATURE REQUEST] Multi Threaded YT Downloads #226

Open iWisp360 opened 2 weeks ago

iWisp360 commented 2 weeks ago

Is your feature request related to a problem? Please describe.

I have slow and limited internet, one download thread is not enough.

Describe the solution you'd like Multithreaded YT downloads by default to improve download speeds

Apps

MSOB7YY commented 2 weeks ago

this will introduce lotta issues, the current implementation literally depends on the file size (bytes) in order to resume downloads. multi threads will write to multiple byte offset, making the current implementation of no use. another way is to split downloads to multiple files but that still requires re-write and of course the bugs are awaiting.

THE THING IS multi threading is not always the solution. it helps only when the server is throttling your connection so u open multiple connections. having slow internet will not really help here


TLDR; might consider it but only on the long run, when most things are already stable enough