search

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter
Other
2.29k stars 139 forks source link

[BUG] YouTube action buttons ui overflow #49

Closed FoxInSmoke closed 1 year ago

FoxInSmoke commented 1 year ago

When switching to Russian, the "save" button moves out. Screenshot_2023-11-06-23-37-42-465-edit_com msob7y namida

MSOB7YY commented 1 year ago

oh thanks for the notice, i thought i left them flexible.. gonna push a fix soon

FoxInSmoke commented 1 year ago

Screenshot_2023-11-06-23-59-25-952-edit_com msob7y namida

MSOB7YY commented 1 year ago

yeah it's limited to 3 lines u may consider reducing font size in customization if u see cut text frequently

not sure if i can increase the limit, since the design will get quite messy

FoxInSmoke commented 1 year ago

You can simply add a setting with a choice of the number of lines, then whoever needs it can choose it themselves

MSOB7YY commented 1 year ago

i mean if im going to add an option for every single issue, the settings page is not going to be usable anymore

im just gonna increase the limit

MSOB7YY commented 1 year ago

yeah this was done in a3a5d310b333aa1c6dbee0cbc7634e257ccd7f5c

max lines was increased in bfdefa555b7fe597cb9966b3d697463de71c2314 too

thanks a lot for reporting