Bug and enhancement - Githubissues

namidaco / namida

A Beautiful and Feature-rich Music & Video Player with Youtube Support, Built in Flutter

Other

2.29k stars 139 forks source link

Bug and enhancement #50

Closed BlackSparkz closed 10 months ago

BlackSparkz commented 1 year ago

Fix all

MSOB7YY commented 1 year ago

investigating
was fixed
not possible, u can swipe to the right a bit to have a peek
maybe its time to reduce font size a bit from Customization Settings, i cant make it take more than 1 line

NikunjKhangwal commented 11 months ago

Can Confirm, expanded lyrics button doesn't work a lot of times for me as well. Also yes make the audio info take two lines if it's overlapping. You can also move the repeat button above queue button since there's enough empty space along with a new "sleep timer" button above lyrics button. (Was going to make a new feature request for sleep timer button)

MSOB7YY commented 11 months ago

@NikunjKhangwal after investigating, it seems like the issue is caused by scaling the artwork (AnimatedScale) which might not allow touches outside the original size.

im not very sure about workarounds, there isnt any place for this button in the miniplayer ui

about making the info 2 lined, and possibly introduce sleep timer (by making 4 squared icons), it will require some painy refactor and i don't think it will even look good, especially the 4 squared icons

ughhh im not sure yet

NikunjKhangwal commented 11 months ago

Yeah, fair point. You should at least make the info take 2 lines tho since that overlap doesn't look good either. Also unless i'm missing something, why do you call the main playing screen "miniplayer"? I thought miniplayer was the one that appears when you swipe down the main player (With only back play/pause and previous button). I'm going to create a issue for this and i don't want it to be confusing.

MSOB7YY commented 11 months ago

okay i will look into that after a while

well to be technically right, its exactly "expanded miniplayer", others could work too like player screen or whatever, its just my view, could be wrong.

u can create the issue with any name u like as long as it's clearly referring to it

NikunjKhangwal commented 11 months ago

Got it, thanks

MSOB7YY commented 11 months ago

with [2031d74bb7c8f06f2c90bbf8ce434f99866d78e8], number 1 (enter lrc fullscreen) can be fixed using 2 ways:

since artwork scaling is now possible, u can make it a bit smaller, this will make the button work properly
you can also just pinch in (zoom) when lrc view is displayed, and it will enter fullscreen

unfortunately, the core issue (button should be pressed) doesnt seem to be fixable, since scaling up the artwork doesnt scale the GestureDetector hit test area.

for reference: