fix: reduce clanBannerKeyMaxLength

[Muparadzi]

Reduced clanBannerKeyMaxLength back to 100 following server crashes caused by #266

[namidaka]

[namidaka]

@Muparadzi any update?

[Muparadzi]

I've not been able to figure out what compression type was causing the issue. Only that the client has an issue spawning agents with a banner displayed if above a certain character count.

On Sun, 17 Mar 2024, 22:37 namidaka, @.***> wrote:

@Muparadzi https://github.com/Muparadzi any update?

— Reply to this email directly, view it on GitHub https://github.com/namidaka/crpg/pull/312#issuecomment-2002641290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGCEV4JNH2ZA7PWDGBQBFLYYYLMFAVCNFSM6AAAAABER5FMP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGY2DCMRZGA . You are receiving this because you were mentioned.Message ID: @.***>

[or2e]

@Muparadzi Probably need a migration that should do something about banners over 100 chars

[Muparadzi]

@Muparadzi Probably need a migration that should do something about banners over 100 chars

We sanitise banners over the limit in game which alleviates any issues caused.

[namidaka]

I've not been able to figure out what compression type was causing the issue. Only that the client has an issue spawning agents with a banner displayed if above a certain character count. … On Sun, 17 Mar 2024, 22:37 namidaka, @.> wrote: @Muparadzi https://github.com/Muparadzi any update? — Reply to this email directly, view it on GitHub <#312 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGCEV4JNH2ZA7PWDGBQBFLYYYLMFAVCNFSM6AAAAABER5FMP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGY2DCMRZGA . You are receiving this because you were mentioned.Message ID: @.>

Just drop me a screenshot of the error message i'll find what's wrong

[Muparadzi]

still waiting for the screenshot of the error message

The following error logs were recorded on the server prior to crashing on 11/03/24.

There is also an issue when an agent is spawned and their bannercode count is high where the client doesn't 'spawn' the agent but the server does. I haven't managed to catch an exception or anything to identify the cause of the clientside issue.

WARNING: Compression info input is not between min and max values. Min: -1.000. Max: 1.000.
[22:50:58.497] #FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:18598
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:22723
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3477836
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:1371298
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:115766
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1253599
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1248686
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:170609
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:901392
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:159470
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451493
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451288
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3453860
#ucrtbase.pdb@{9FB5798C91EBCA528CADC890FF6E04FF} (1): 0:140938
#kernel32.pdb@{EB7C2B38022D10C4BA504711C747F0E2} (1): 0:96964
#ntdll.pdb@{CDFF9FBD905A3860C6760DCE054E50A4} (1): 0:369489
-----------------------------------------------
#TaleWorlds.DotNet.AutoGenerated.pdb@{82A9819E82D44838BB220EEBC51FC3ED} (1): 100663331:0

[22:50:58.497] Skipping report generation. Error reporting disabled.

[22:50:58.498] Messagebox [Always Ignore?] message: Would you like to always ignore this failure?

WARNING: Compression info input is not between min and max values. Min: -3.142. Max: 3.142.
[22:50:58.108] #FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:18598
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:22723
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3477836
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:1371298
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:115766
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1253599
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1248686
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:170751
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:901392
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:159470
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451493
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451288
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3453860
#ucrtbase.pdb@{9FB5798C91EBCA528CADC890FF6E04FF} (1): 0:140938
#kernel32.pdb@{EB7C2B38022D10C4BA504711C747F0E2} (1): 0:96964
#ntdll.pdb@{CDFF9FBD905A3860C6760DCE054E50A4} (1): 0:369489
-----------------------------------------------
#TaleWorlds.DotNet.AutoGenerated.pdb@{82A9819E82D44838BB220EEBC51FC3ED} (1): 100663331:0

[namidaka]

still waiting for the screenshot of the error message

The following error logs were recorded on the server prior to crashing on 11/03/24.

There is also an issue when an agent is spawned and their bannercode count is high where the client doesn't 'spawn' the agent but the server does. I haven't managed to catch an exception or anything to identify the cause of the clientside issue.

WARNING: Compression info input is not between min and max values. Min: -1.000. Max: 1.000.
[22:50:58.497] #FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:18598
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:22723
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3477836
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:1371298
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:115766
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1253599
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1248686
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:170609
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:901392
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:159470
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451493
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451288
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3453860
#ucrtbase.pdb@{9FB5798C91EBCA528CADC890FF6E04FF} (1): 0:140938
#kernel32.pdb@{EB7C2B38022D10C4BA504711C747F0E2} (1): 0:96964
#ntdll.pdb@{CDFF9FBD905A3860C6760DCE054E50A4} (1): 0:369489
-----------------------------------------------
#TaleWorlds.DotNet.AutoGenerated.pdb@{82A9819E82D44838BB220EEBC51FC3ED} (1): 100663331:0

[22:50:58.497] Skipping report generation. Error reporting disabled.

[22:50:58.498] Messagebox [Always Ignore?] message: Would you like to always ignore this failure?

WARNING: Compression info input is not between min and max values. Min: -3.142. Max: 3.142.
[22:50:58.108] #FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:18598
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:22723
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3477836
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:1371298
#FairyTale.Library.pdb@{D03221FAC1524B8EAF68C66B86B1CE3E} (1): 0:115766
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1253599
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:1248686
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:170751
#Game.pdb@{118EFF46575342C0952D90C79811E584} (1): 0:901392
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:159470
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451493
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3451288
#Rgl.pdb@{236D13FD42904CDFAD994EBB12D61A60} (1): 0:3453860
#ucrtbase.pdb@{9FB5798C91EBCA528CADC890FF6E04FF} (1): 0:140938
#kernel32.pdb@{EB7C2B38022D10C4BA504711C747F0E2} (1): 0:96964
#ntdll.pdb@{CDFF9FBD905A3860C6760DCE054E50A4} (1): 0:369489
-----------------------------------------------
#TaleWorlds.DotNet.AutoGenerated.pdb@{82A9819E82D44838BB220EEBC51FC3ED} (1): 100663331:0

first one is flag progress

Second one is easy to guess it's rotation not being between -360 and +360 (it's Pi)

[Muparadzi]

first one is flag progress Second one is easy to guess it's rotation not being between -360 and +360 (it's Pi)

Although these are the only logs in crpg01e that I can find that occurred around the time of the crash. I can see that this compression issue occurred as late as 21/03 where the bannercode limit was reduced to 100. So I don't think these are related to the bannercode issue after having another look.

[namidaka]

first one is flag progress Second one is easy to guess it's rotation not being between -360 and +360 (it's Pi)

Although these are the only logs in crpg01e that I can find that occurred around the time of the crash. I can see that this compression issue occurred as late as 21/03 where the bannercode limit was reduced to 100. So I don't think these are related to the bannercode issue after having another look.

second one is siegemachines :

[namidaka]

first one is flag progress Second one is easy to guess it's rotation not being between -360 and +360 (it's Pi)

Although these are the only logs in crpg01e that I can find that occurred around the time of the crash. I can see that this compression issue occurred as late as 21/03 where the bannercode limit was reduced to 100. So I don't think these are related to the bannercode issue after having another look.

second one is siegemachines :

[namidaka]

@Muparadzi what's the status?

[Muparadzi]

@Muparadzi what's the status?

I've just had some time this evening to try to replicate the issue locally, which I am able to do. Using a bannercode of about 958 characters, when I join a server it essentially grinds to a halt.

However, in this instance, I do not receive any errors in my server or client so debugging is proving quite difficult at the minute. I'll see if I can get any more info.