search

namidaka / crpg

Multiplayer mod for Mount & Blade II: Bannerlord
https://c-rpg.eu
GNU General Public License v3.0
14 stars 14 forks source link

cannot swap to a team after joining spectator #336

Closed Muparadzi closed 6 months ago

Muparadzi commented 6 months ago

players are preventing from joining a team during a mission in-progress after they have been on the spectator team.

this is currently an issue in Conquest & Battle, presumably caused by the balancer not letting them select a team.

Muparadzi commented 6 months ago

HandleTeamChange in CrpgTeamSelectServerComponent.cs adds players who wish to change from spectator to a list to include in the next team balance.

In conquest, the team balance only happens at the end of the warmup. Implementing it anywhere else in the gamemode would remove any consistency with attackers/defending swapping sides throughout the mode. Therefore, players waiting to join a team are stuck in limbo until the end of a map.