namidaka / crpg

Multiplayer mod for Mount & Blade II: Bannerlord
https://c-rpg.eu
GNU General Public License v3.0
14 stars 14 forks source link

webui: ability to quick equip items #343

Closed antibert closed 3 months ago

antibert commented 5 months ago

proposed implementation of #33

draft PR for initial review

possible additions:

@or2e requesting your view on the above points

TODO:

or2e commented 5 months ago

very cool yes, you need to put the common logic in separate functions (service or cosposable), I'll wait for it

also, you and I have discussed: shortcut tips

I suggest placing a tips under the doll ![image](https://github.com/namidaka/crpg/assets/33551334/979682bd-e4e0-44eb-8f41-cba8171630e7)

ready-made UI components and an example of their use, you can find here ui/KbdGroup.vue

or put the hints in the tooltip, also a great option))

antibert commented 4 months ago
Here is what the tip currently looks like

Do you think conveying "LMB" with the key component is sufficient or should it be replaced with an icon?

Also did some refactoring, added unit tests and processed review comments.

antibert commented 4 months ago

I think this PR is ready 😳

antibert commented 3 months ago

Awesome! Thanks for your contribution to the mod!

For equipment that we might want to equip multiple of (for example arrows), currently you can only fill one slot with an item using ctrl click.

Good point, I removed the restriction and made the locales consistent.