search

namidaka / crpg

Multiplayer mod for Mount & Blade II: Bannerlord
https://c-rpg.eu
GNU General Public License v3.0
14 stars 14 forks source link

feat: personal items #349

Closed or2e closed 1 month ago

or2e commented 4 months ago

closed: https://github.com/namidaka/crpg/issues/13 https://github.com/namidaka/crpg/issues/35

or2e commented 3 months ago

Yeah, I also didn't write the tests I suggest to get in touch sometime and discuss this mr.

Muparadzi commented 1 month ago

Should we disable the ability to heirloom or reforge personal items? Will we ever reward personal items that are also available in the store?

or2e commented 1 month ago

Looking good!

Would we need to disable the items using the API after they are added? I don't think we support creating disabled items from the start in items.json.

added an extra prefix ![image](https://github.com/user-attachments/assets/eac76655-8725-475f-ad94-32cdec886fb9)
or2e commented 1 month ago
  • There is a bug where reforging or looming a personal item will turn it into a 'normal' item
  • If you are given a personal item that you have already purchased from the store, all of the items with the same item id will become personal.

Should we disable the ability to heirloom or reforge personal items? Will we ever reward personal items that are also available in the store?

1/ After changing the architecture (prop personal is now attached on UserItem entity), 1 bug was fixed. Let there be the possibility of loom/reforege.

2/ I can forbid the transfer of usual items, but let it be for now.

~~3/ I think I'm left to figure out what to do when an item is rebalanced and has a id change (ex. v2 -> v3). For example, I can somehow by working with strings and regular expressions to automatically add a new version of a personal item.~~

fyi: @Meowkov @MrMendo