search

namilus / denote-menu

View and filter Denote files in a tabulated list
https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html
GNU General Public License v3.0
51 stars 11 forks source link

filtering exits with an error #7

Closed j4kub5 closed 1 year ago

j4kub5 commented 1 year ago

Running denote-menu-filter and denote-menu-filter-by-keyword returns an error:

denote-menu-get-path-by-id: Symbol’s function definition is void: seq-positions

My config, if needed for reproducing the error: https://github.com/Jack8472/lemacs

namilus commented 1 year ago

Thanks for spotting this! What version of emacs are you running? It looks like `seq-positions' was only introduced in emacs 29. I'll rewrite the function so it is compatible with at least emacs 28.1

j4kub5 commented 1 year ago

I use emacs 28.2 (on archlinux) and 28.1 (on windows).

namilus commented 1 year ago

In the most recent commit (210396d), I've removed the call to seq-positions and re-implemented denote-menu-get-path-by-id using functions that should be available in emacs 28.1. That should fix things

j4kub5 commented 1 year ago

I confirm. Update by quelpa-upgrade fixed the issue. Thank you very much!