namilus / denote-menu

View and filter Denote files in a tabulated list
https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html
GNU General Public License v3.0
51 stars 11 forks source link

feat request: Add one column display denote signature #8

Closed Jousimies closed 1 year ago

Jousimies commented 1 year ago

Now denote had merged signature branch to main, current denote menu can only show Date, Title and Keywords.

Can add one column to display signature ?

EFLS commented 1 year ago

I've added some code to do display such a column in my personal branch of denote-menu. I'll attach the code changes as a patch.

I'm not sure how to turn this into an option one could toggle on and off, as I'm not familiar enough with tabulated-list-mode.

0001-add-signature-to-tabulated-view.patch

namilus commented 1 year ago

Hi @Jousimies @EFLS,

Thank you for your patch. I'll take a look at it in the coming days and edit it to allow for a custom user option to toggle the column

Jousimies commented 1 year ago

@EFLS Thank you for your patch, it worked.

The problem is when use regexp to filter some candidate, it runs very slowly. No sure, what caused this problem, I will try to explore it.

anthrolisp commented 1 year ago

This would be incredible to include. In the meantime, how to add this manually to the init file? Thank you in advance!

namilus commented 1 year ago

Hello everyone @anthrolisp @Jousimies @EFLS ,

Sorry for the late development. I have added the feature for an optional column to include denote file signatures.

Please try out the most recent changes and see if everything is working correctly.

In the meantime I will prepare an update for ELPA to include the new feature.

Thank you.