search

namiyousef / multi-task-learning

Repository for multi task learning
2 stars 2 forks source link

L1 loss used for bounding box? #3

Open namiyousef opened 2 years ago

namiyousef commented 2 years ago

In criterion.py under get_loss(), the L1Loss is used for task=="BB". Is there a reason for this? Why wasn't IoU used?

ConnorWatts commented 2 years ago

No reason just was easy at the time but I agreed that iou would be better

I've made a class IoULoss in loss_functions but not done anything in it - if someone could have a look and try update/send me a design I'll update it

Sent from my Galaxy

-------- Original message -------- From: Yousef @.> Date: 06/01/2022 21:15 (GMT+00:00) To: namiyousef/multi-task-learning @.> Cc: Subscribed @.***> Subject: [namiyousef/multi-task-learning] L1 loss used for bounding box? (Issue #3)

In criterion.py under get_loss(), the L1Loss is used for task=="BB". Is there a reason for this? Why wasn't IoU used?

— Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnamiyousef%2Fmulti-task-learning%2Fissues%2F3&data=04%7C01%7C%7C216f3bc2521a49cf56d408d9d159a6fd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637771005240222103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=0ubwk9r0bkgjIP3EGrw9pTVGaFNHjiXl1Z5tz7jSePs%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQBIA5EODCSUGT4SS5A6ORTUUYA6VANCNFSM5LNHWBWQ&data=04%7C01%7C%7C216f3bc2521a49cf56d408d9d159a6fd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637771005240222103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=caPTNALRyfG0LHPpHl%2BTdLZUhyO1qIdt%2FaOG1SH0WfQ%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C216f3bc2521a49cf56d408d9d159a6fd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637771005240222103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NT3UYli82uECWEhzdbu%2FWfcm5ZG8FiUx4Rp%2BpLoU7jA%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C216f3bc2521a49cf56d408d9d159a6fd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637771005240222103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=p2NOLBiB0Q%2FP9903mdNKev5TOnlh3DbIn5qWUf%2FL8bE%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

namiyousef commented 2 years ago

Useful Links: