search

namjaejeon / ksmbd-tools

ksmbd kernel server userspace utilities
GNU General Public License v2.0
55 stars 43 forks source link

ksmbd.service.in #183

Closed thomzieg closed 2 years ago

thomzieg commented 2 years ago

Hi, I think line 3 in ksmbd.service.in is not right, it should probably read Requires=modprobe ksmbd

atheik commented 2 years ago

@thomzieg,

Your suggestion is not a valid value for the Requires= option. The current value of modprobe@ksmbd.service is correct. systemd v245 and later ship with modprobe@.service. The ksmbd.service unit file is installed automatically for those versions of systemd. What prompted this issue?

thomzieg commented 2 years ago

Hi sorry now I see the problem. I'm on Centos 7 with systemd v219 and no ksmbd.service unit. I guess this is the reason why building ksmbd-tools with systemd support also gives an error. Therefore, I will close this issue.

atheik commented 2 years ago

@thomzieg,

How are you building ksmbd-tools? If the build system does not have systemd v245 or later, then the build succeeds but ksmbd.service is not installed. Or, are you using ksmbd-tools.spec of this repository? The spec file does require systemd v245 or later at package-installation time.

thomzieg commented 2 years ago

I've tried to force it by --with-systemdsystemunitdir but ran into an error which looked like a bug in the Makefile. But with latest git even this error has vanished, and everything looks clean. I have now my own ksmbd.service file with ExecStartPre=-/sbin/modprobe ksmbd Thanks for following up.