search

namjaejeon / ksmbd-tools

ksmbd kernel server userspace utilities
GNU General Public License v2.0
52 stars 42 forks source link

ksmbd-tools: add a crossmnt parameter in smb.conf #194

Closed namjaejeon closed 1 year ago

namjaejeon commented 1 year ago

This patch add a new 'crossmnt' parameter in smb.conf to allow path lookup to cross a mountpoint to the root of a different filesystem. e.g. if there is sda1 directory in ksmbd share and sda1 directory is mounted as external devices(e.g. usb), currently files in sda1 is not visiable from client. User can control path lookup for cross mount points using this parameter.

namjaejeon commented 1 year ago

@atheik Can you review this patch ? Thanks!

atheik commented 1 year ago

@namjaejeon Other than the missing .TP, it looks all good to me. I tested the crossmnt functionality with the out-of-tree ksmbd (https://github.com/namjaejeon/ksmbd/pull/437/commits/34cf739).

namjaejeon commented 1 year ago

@atheik Thanks for your review! I updated it now.

namjaejeon commented 1 year ago

@atheik Thanks! I will add your Acked-by tag.