search

namreeb / namigator

An intelligent navigation API for World of Warcraft Alpha, Vanilla, TBC and WotLK
MIT License
49 stars 32 forks source link

query_z wrong inside caves #38

Closed namreeb closed 1 year ago

namreeb commented 1 year ago

Example 1: Map 0 ADT 50, 31 -9849.028, 134.545, 5.815 query_z returns a list of three identical values of 35.582 Example 2: Map 0, ADT 48, 32 -8617.701, -147.215, 87.239 query_z returns a list of three identical values of 145.589

devw4r commented 1 year ago

image

Location - Map 0, X -8647.1396484375 Y -129.36000061035156 Real Z 87.70490264892578 Namigator query_z results: Namigator Z[0] 114.20716094970703 Namigator Z[1] 114.20716094970703 Namigator Z[2] 114.20716094970703 Namigator Z[3] 114.20716094970703

image

Location - Map 0, X -8590.5458984375 Y -143.14688110351562 Real Z 89.60712432861328 Namigator query_z results: Namigator Z[0] 156.3370361328125 Namigator Z[1] 156.3370361328125 Namigator Z[2] 156.3370361328125

image

Location - Map 0, X -9788.1455078125 Y 147.7585906982422 Real Z 25.114551544189453 Namigator query_z results: Namigator Z[0] 58.94005584716797 Namigator Z[1] 58.94005584716797

image

Location - Map 0, X -11125.2783203125 Y -117.76166534423828 Real Z 10.532085418701172 Namigator query_z results: Namigator Z[0] 50.5771369934082 Namigator Z[1] 50.5771369934082 Namigator Z[2] 50.5771369934082

image

Location - Map 0, X -13295.9755859375 Y -480.9395446777344 Real Z 17.734399795532227 Namigator query_z results: Namigator Z[0] 77.89437103271484 Namigator Z[1] 77.89437103271484 Namigator Z[2] 77.89437103271484 Namigator Z[3] 77.89437103271484

namreeb commented 1 year ago

Can you try with commit https://github.com/namreeb/namigator/commit/496e0072d746faceabef6e03d4b796e95120dc93 and let me know if its fixed? It seems to be for me.

devw4r commented 1 year ago

Finding some of the same issues:

image

image

image

[WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -113.66188118598966 Y -415.68063786502023 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -52.98414811817273 Y -404.6679182134722 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -99.05539023853669 Y -433.4828294287597 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -22.19026608605617 Y -372.92802430483823 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -85.83877585905162 Y -407.5936918675725 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -103.24486186286511 Y -422.2851826215904 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -117.50086350048163 Y -406.21428165144926 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -99.79032538194552 Y -435.4220108276871 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -59.987763106357264 Y -407.54760708826984 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -94.01510938494012 Y -397.6855763888393 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -120.92418182256282 Y -441.5841385397085 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -4.027497725276605 Y -373.58048995359695 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -98.8584310890257 Y -402.0632847026719 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -106.85908425630286 Y -426.70039757306773 [WARNING] [NAMIGATOR] Unable to find Z for Map 36 ADT [32,32] X -124.70499273772934 Y -439.12063135930964

Map 0: [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8664.270330762934 Y -124.54071872331039 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8664.163085768967 Y -124.5450968288723 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8664.064814368285 Y -124.54910860182302 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8663.95618095669 Y -124.55354338731665 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8663.849080644037 Y -124.55791558649499 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8663.74090608298 Y -124.56233164014837 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8663.638835770127 Y -124.56649849761995 [WARNING] [NAMIGATOR] Unable to find Z for Map 0 ADT [48,32] X -8663.532299239632 Y -124.5708476812923

namreeb commented 1 year ago

Haven't looked at map 36 yet, but the failures in the screenshots above should all be fixed by https://github.com/namreeb/namigator/commit/e66fe54ca9a71592f31e447730c2a9789efb63bd.

namreeb commented 1 year ago

Going to close this for now. But please do let me know if there are any other places where query_z fails.