search

namreeb / wowreeb

An intelligent, versatile, and multi-versioned World of Warcraft launcher
MIT License
58 stars 32 forks source link

Default FOV if value is missing #4

Closed joao-fidalgo closed 7 years ago

joao-fidalgo commented 7 years ago

Wowreeb shouldn't change the field of view if a value isn't set on config.xml

namreeb commented 7 years ago

Is it doing so? It seems like the default value is 0, and it won't be set if the value is <= 0.1

joao-fidalgo commented 7 years ago

I removed the FoV node, and it was setting a custom FoV anyways.

namreeb commented 7 years ago

I'm not able to reproduce this. Note that if you update the config, you have to restart the systray app. Maybe I should add a background thread to monitor the file for changes and load them. Can you confirm if restarting the launcher solves your issue?

joao-fidalgo commented 7 years ago

You're right. I might botched it up by changing config.xml and not restarting wowreeb.exe.

Anyways i feel like the default FoV on config.xml shouldn't be that high, and should be set to the default value, 1.570796371 according to OwnedCore.

namreeb commented 7 years ago

There is no default value.