search

namshi / cuzzle

This library let's you dump a Guzzle request to a cURL command for debug and log purpose.
https://github.com/namshi/cuzzle
330 stars 67 forks source link

Fix escapeshellarg Fatal Error Exception #19

Closed tchoulom closed 7 years ago

tchoulom commented 7 years ago

[X] Fix escapeshellarg Fatal Error Exception while sending a request to a Rest API.

cirpo commented 7 years ago

@tchoulom could you please remove the .idea files? Could you also please add a test?

tchoulom commented 7 years ago

@cirpo Thank you for your comment. [X] I removed the the .idea files [X] I also added the phpunit test for this pull request

tchoulom commented 7 years ago

[X] Comment the change in CurlFormatter.php: // $contents = str_replace(chr(0), '', $contents); [X] Then throws the FatalErrorException in CurlFormatter.php

tchoulom commented 7 years ago

@cirpo I already added a test in C:\wamp\www\cuzzle\tests\Formatter\CurlFormatterTest.php

tchoulom commented 7 years ago

@cirpo So I remove my change in the .gitignore file ?

cirpo commented 7 years ago

@tchoulom test are failing

tchoulom commented 7 years ago

@cirpo

As you can see :

I removed my change in gitignore file The test is also OK : https://travis-ci.org/namshi/cuzzle/builds/167973355