search

namshi / cuzzle

This library let's you dump a Guzzle request to a cURL command for debug and log purpose.
https://github.com/namshi/cuzzle
331 stars 68 forks source link

data support for GET request #7

Closed zainengineer closed 9 years ago

odino commented 9 years ago

hey @zainengineer, thanks for the PR! Would you be able to cover this case with tests?

cheers

zainengineer commented 9 years ago

@odino thanks for merging. Should I modify https://github.com/namshi/cuzzle/blob/master/tests/Formatter/CurlFormatterTest.php ?

1) Add an assertion that in testPost() that it does contain -d but not -G. 2) Add a section in testGETWithQueryString() which provides query string using data and assert that output contains both -d && -G

does this sound right?

odino commented 9 years ago

Still not merged yet -- we need the tests :) I would say yes, both of them sound good to me

zainengineer commented 9 years ago

@odino
I added assertion for for testGETWithQueryString() and in testPost(). Should I rebase and make a new merge request? or is it ok?

cirpo commented 9 years ago

@zainengineer thanks for this PR, can you squash it? I'm going to merge it then

cirpo commented 9 years ago

@zainengineer, could you please squash it on your side? thanks

odino commented 9 years ago

Done in master

odino commented 9 years ago

new tag, 1.2.1, is out