search

namshi / docker-smtp

SMTP docker container
MIT License
549 stars 199 forks source link

Add ability to listen on an environment-specified port #11

Closed MartijnVdS closed 8 years ago

MartijnVdS commented 8 years ago

The port defaults to "25" as before, but can be overridden by providing the PORT environment variable on startup.

oba11 commented 8 years ago

oh cool , please lets remove the line here and its good to merge.

MartijnVdS commented 8 years ago

That would require other users to explicitly expose the port using -p 25:25 or similar -- just using docker run -P won't expose it anymore, making the change backward-incompatible in that regard.

MartijnVdS commented 8 years ago

I've removed the EXPOSE line.

oba11 commented 8 years ago

sorry about missing that part @MartijnVdS , it would break backward compatibility or anyone using -P, please add it back and good to merge. apologies for trouble.

MartijnVdS commented 8 years ago

@oba11 Done!

oba11 commented 8 years ago

thanks