Make ext-openssl and phpseclib optional dependencies

namshi / jose

JSON Object Signing and Encryption library for PHP.

MIT License

1.8k stars 133 forks source link

Make ext-openssl and phpseclib optional dependencies #89

Closed kelunik closed 8 years ago

kelunik commented 8 years ago

PR for #88. Please note that this will require a new major version since phpseclib would get removed with an update even if it's used in a project. It has to be explicitly required after this PR.

odino commented 8 years ago

@kelunik looks good. Shallwe go for a major release so that others can upgrade as they want? I guess a bunch of people would want to rely on having those libraries installed, whereas others wouldnt mind at all :)

kelunik commented 8 years ago

If you don't have any other breaking changes pending and think this change satisfies a new major version by itself, go ahead.

odino commented 8 years ago

thanks man!