search

namshi / winston-graylog2

Graylog2 transport for winston, a nodejs logging module
MIT License
126 stars 98 forks source link

winston transport legacy #66

Closed ShintaroNippon closed 5 years ago

ShintaroNippon commented 5 years ago

Please, I only need to check this line!

https://github.com/namshi/winston-graylog2/blob/master/lib/winston-graylog2.js#L63
let Graylog2 = (winston.transports.Graylog2 = function(options) {

because I had doubts... Thanks Carlos Vieira

odino commented 5 years ago

Hi @ShintaroNippon,

thanks for this submission! Unfortunately the tests after your changes are not passing, can you have a look?

ShintaroNippon commented 5 years ago

Sorry about the first commit... Now should be ok with tests.

Please check! thanks in advance

odino commented 5 years ago

Perfect, would you mind clarifying what this change does and why do we need it? :)

ShintaroNippon commented 5 years ago

Sure!, it's in order to resolve this issue: https://github.com/namshi/winston-graylog2/issues/65

Transport legacy. Thanks Carlos Vieira

odino commented 5 years ago

Ok, I'll now release a new minor version

odino commented 5 years ago

in v1.1.0