Thanks!

[coderschoolreview]

Hi @namtran0110 , thanks for your submission. Good job for the pre-work ! But unfortunately, when we check, some required features haven't done yet.

The goal of prework is to provide a small challenge for serious applicants to help us screen for people with a strong motivation and commitment for the course. It is also intended to be a useful and fun exercise.

You should continue to finish and improve your pre-work then re-submit to us. To be clear, this is missing required feature:

• There is one post that introduces the App Creator with name, picture.
• User can delete stories, with an alert that asks the user to confirm.
• User can submit a search term to find all posts bywith titles containing the search term.

Try to finish it and add more optional/additional feature will help your submission stand out from others.

About your note:

We're sorry to hear that. Our recommendation is using Boostrap V4-Alpha. You can find example for navigation bar here.

Feel free to edit and update your submission then tell us to re-check it. If you have any questions or you need any support, feel free to contact us via gitter chat or email us.

We're looking forward to see your improvement.

[coderschoolreview]

Next step

Let's schedule a quick call to confirm that this course is a right fit for you. We also would like to know a little more about your experience. Please book a slot from here.

[coderschoolreview]

Hi @namtran0110 , We love to see your improvement, you did a good job so far. All missing feature are now fixed. This is some quick feedback from us:

• It's great to follow a good Ruby code style. We recommend this: Ruby Style Guide
• For navigation bar, the best way to make it display in all page is put it in application.html.rb. And you should also put your search bar in navigation bar, using bootstrap form-inline is recommended. This is example for that: (checkout bootstrap's example for more details: Bootstrap Inline SearchBar)

  <form class="form-inline my-2 my-lg-0">
  <input class="form-control mr-sm-2" type="text" placeholder="Search">
  <button class="btn btn-outline-success my-2 my-sm-0" type="submit">Search</button>
  </form>

• You should also use bootstrap form-group style for your creating article form as well
• Your article details page didn't show rendered content in markdown. Try to use RedCarpet there, it's very similar to what you've used in your index method.
• Good news is Heroku has worked with the Rails core team to make Rails 5 work on twelve-factor platforms out of the box. So you don't have to use gem "rails_12factor" anymore.
• We saw that you use gem "searchkick" to support search feature. But you know, for this pre-work, we can simplify this with single line of code to query in ActiveRecord like this:

Article.where("title like ?", params[:search])

• Last but not least, you should have validation in your model to prevent user input wrong/empty record. This is sample:

# article.rb
validates :title, :body, presence: true
# comment.rb
validates :message, presence: true

You can continue improve your app and request us to review it again anytime, we love to see your progress has been improve day by day. Thanks for your hard work ! And now, if you haven't take an interview with us , please book a slot from here.