Open thisconnect opened 6 years ago
This:
The solution would be to change process.on('exit')
's handler to check if there's a nonzero return code and return that first, before returning the number of errors encountered.
At work right now so I can't make this change but PRs are welcome! Should be a good starter contribution. :)
I tried writing a test, not sure if that is good enough
/* Modules */
var test = require('tape');
/* Tests */
test('halt and catch fire', function(assert) {
assert.plan(1);
throw new Error('something broke')
});
unfortunately the code is 0 process.on('exit', function (code) {
, my guess is TAP just streams the error in TAP format, so no exit code
I am not sure if I'm able to solve this. Another question, why does it use tap-parser-yaml
and not tap-parser
?
any idea why this exits with 0?
https://travis-ci.org/thisconnect/tools/jobs/295026162#L2141