search

namuol / tap-difflet

TAP output formatter using difflet for inequality errors.
48 stars 8 forks source link

Do not treat `extra` as an error. #2

Closed nowells closed 9 years ago

nowells commented 9 years ago

I might be missing something in the spec, but I don't think extra maps to an error state? tap-spec only treats it as additional output: https://github.com/scottcorgan/tap-spec/blob/master/index.js#L92

@namuol what do you think? Was there a reason behind extra -> error. If you agree with this I will add tests and defer to you for review.

namuol commented 9 years ago

I think extra blocks were treated as errors in the original version of tap-min that I forked. I can see how this might cause false errors when all tests actually succeed, though. If you're using this on your end, merge away. :)

namuol commented 9 years ago

Duplicate of #3 -- fixed now.