search

nan0s7 / nfancurve

A small and lightweight POSIX script for using a custom fan curve in Linux for those with an Nvidia GPU.
GNU General Public License v3.0
315 stars 58 forks source link

Adding options and some formatting #2

Closed dpayne closed 6 years ago

dpayne commented 6 years ago
  1. Adding parameters to pass in config file and display device. This is useful when running it as a startup script.
  2. Reformatting to make tabs consistent.
  3. Settings fan speed immediately on startup. I'm not sure this is strictly needed but it helped to immediately reduce the fan speed if the temps were low enough.
nan0s7 commented 6 years ago

Hey thanks for the contribution!! Technically the tabs were consistent but they were only 4-spaced tabs instead of 8. I'm a bit busy right now so I don't know when I'll get around to merging this, but before I do I'd like to have a more thorough look through your changes. Just thought I'd leave this comment so you know I saw this and will certainly be merging sometime soon. :)

nan0s7 commented 6 years ago

Alright I've gotten around to testing the changes. I will merge it, and I'll be changing the help text formatting slightly.

With change 3. I noticed that it first changed the fan speed to zero, then to whatever it calculated. For me personally I've never had a problem with the way it handled setting the fan speed before unless it was a non-zero speed already. Making it default to the lowest given fan speed may solve that issue.

dpayne commented 6 years ago

I removed the change for #3. I don't think it was really need.