Closed fastrizwaan closed 5 years ago
The window corners already have 2px border-radius
.
2px
is the recommended radius for many components in the Material Design guidelines, so I don't want to change it.
Sorry but I won't fix it.
@nana-4 considering the recent changes in many Google products and material design, a larger corner-radius seems preferred these days.
@nana-4 sorry for offtopic but i've read the updated material design guide and it seems what now they have a slightly different buttons design: https://material.io/design/components/buttons.html
on topic: i think for window decorations it's reasonable to stick with chrome os style, which on the screenshots seems to be similar to current materia borders' rounding
also idk if Android-x86 could be referred (since it's not an official google project), but they also have square decorations:
also speaking of new material design and rounding -- it seems what for "main" windows it stay with square corners however for popups/dialogs they now have big rounding as in buttons
Hey @gregor160300 & @actionless, thanks for your suggestions. :)
I had already noticed the roundness change in the guidelines and tried adapting it to Materia. However, frankly speaking I'm quite hesitating about it because the 4px roundness may look too pop/soft:
(I made a test branch so you can easily try it:)
cd /tmp && wget -qO - https://github.com/nana-4/materia-theme/archive/4px-roundness.tar.gz | tar xz
cd materia-theme-4px-roundness
./install.sh -d ~/.themes -n Materia-4px-roundness -c standard -s standard
What do you think? I'm currently thinking I want to wait and see for now while watching the trends of other Material Design products (like material-components-web and demos). :wink:
it seems what for "main" windows it stay with square corners
I forgot about it. Thanks!
However, personally I'd much prefer the rounded top corners for main windows. To me the square corners (with headerbar) looks out of place. Even on Android P, windows are rounded in the overview, so I would like to keep the rounded corners for main windows. :)
I am already enjoying this little extra roundness, also adding roundness to the bottom corners would be awesome (I know it is difficult for GTK 2). I have been using this theme too for a while: https://github.com/vinceliuice/Canta-theme I really like the corner radius on it, but it's compact version doesn't work so I can't keep using it. Also the material-components-web demo already has new images on the overview page, showing it is going towards more roundness as well.
Edit: personally I feel like 8px would be more in line with the new design Google uses (take a look at their login page for example)
also i was thinking, mb to make overall theme roundness configurable via ./change-color.sh, the same as in Numix-based change-color.sh script?
for that instead of using hardcoded roundness in-place, you could define some kind of roundness multiplier in _colors.sass and use it in every border-radius definition
Now, converting the corner radius to 4px is almost done.
I'm closing this. Thanks for your feedback!
personally I feel like 8px would be more in line with the new design Google uses
At least the guidelines do not recommend 8px corner radius to cards by default, so I will pass on that this time. :)
The corners are almost square and too pointed, could you please consider a little rounded corners on top left and top right for the window edges like adwaita and elementary theme, here's elementary window:
elementary style with a bit rounded window edges like adwaita:
material light (easy to distinguish the edges)