search

nana-4 / materia-theme

A Material Design theme for GNOME/GTK based desktop environments
GNU General Public License v2.0
3.42k stars 254 forks source link

rsvg-convert for rendering PNG assets #202

Open nana-4 opened 6 years ago

nana-4 commented 6 years ago

I really want to use rsvg-convert to render PNG assets because it is much faster than inkscape. However, due to some rendering bugs we cannot migrate to rsvg-convert yet.

When these problems are solved, I'd migrate to rsvg-convert.

nana-4 commented 6 years ago

These are the actual problems:

1. Too much spaces with rotated (transform="rotate()") assets.

with inkscape: https://github.com/nana-4/materia-theme/blob/master/src/gtk/assets/scale-vert-marks-after-slider-dark.png with rsvg-convert: https://github.com/nana-4/materia-theme/blob/wip/rsvg/src/gtk/assets/scale-vert-marks-after-slider-dark.png

2. Unclipped spaces (with clip-path="url()").

with inkscape: https://github.com/nana-4/materia-theme/blob/master/src/gtk-2.0/assets-dark/combo-ltr-button.png with rsvg-convert: https://github.com/nana-4/materia-theme/blob/wip/rsvg/src/gtk-2.0/assets-dark/combo-ltr-button.png

3. Not very good drop shadow rendering. (Carefully compare the button's drop shadows.)

with inkscape: image with rsvg-convert: image

nana-4 commented 6 years ago

wip/rsvg is a test branch using rsvg-convert.

actionless commented 6 years ago

if rendering became any better when fixing the IDs? https://github.com/nana-4/materia-theme/issues/246

actionless commented 5 years ago

could you try once again with resvg 0.4?

i've just tried a test rendering and didn't found any observable issues