search

nana-4 / materia-theme

A Material Design theme for GNOME/GTK based desktop environments
GNU General Public License v2.0
3.42k stars 255 forks source link

GNOME Shell: Dialog shadows are cut off on the left #364

Open flipflop97 opened 5 years ago

flipflop97 commented 5 years ago

Reporter Info

Actual Issue

The left sides of the shadows on shell popup menus have their shadow clipped off, the right sides don't. This happens since the update to Gnome 3.32. See the screenshot below for how it looks like.

Screenshot from 2019-03-18 19-19-57

nana-4 commented 5 years ago

Thanks for the report.

This is an upstream bug, and unfortunately cannot be fixed on the theme side :(

Can you report this to the upstream?

flipflop97 commented 5 years ago

Reported it upstream:
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1090

nana-4 commented 5 years ago

@flipflop97 Thanks a lot!

nana-4 commented 5 years ago

Thanks to @hrdwrrsk's workaround, the shadow has been fixed in menus.

The bug still remains in dialogs, though.

berkiyo commented 4 years ago

Hey nana-4, would it be possible to remove the shadows in the dialogs for the time being? For instance, the shutdown, logout and password prompt dialogs? I noticed some themes take this approach and it certainly fixes it. It shouldn't affect the legibilitiy as the background already is dimmed. It's purely an aesthetic thing but it should clean things up n icely and be a suitable workaround, up to you of course. :)

image

nana-4 commented 4 years ago

@berkiyo Sorry for the late reply. Honestly, I'm not thinking of removing the shadows even as a workaround. It's because:

  1. This is not such an annoying problem for me (because of the dimmed background).
  2. Material Design guideline doesn't recommend removing the shadows.
  3. Removing the shadows from gnome-shell dialogs makes them inconsistent with GTK dialogs.

I'm just hoping that upstream will fix that at some point :)

berkiyo commented 4 years ago

@nana-4 No problem. That's fair, after all its an upstream issue. Thanks for getting back to me.