search

nana-4 / materia-theme

A Material Design theme for GNOME/GTK based desktop environments
GNU General Public License v2.0
3.43k stars 257 forks source link

change_color.sh: Default theme location for gtk2 based apps #568

Open rudrab opened 3 years ago

rudrab commented 3 years ago

Hi, There are still some apps, e.g. pidgin, which is using gtk2. The problem is as materia-theme now uses meson build, which installs the theme in ~/.local/share, the location is invisible to pidgin. Now, I have installed the materia theme using meson, and then copied it to ~/.themes again to make it visible to pidgin.

Is there any other way for gtk2 based apps?

nana-4 commented 3 years ago

Hi, it seems GTK 2 themes aren't loaded from ~/.local/share/themes. Arc theme's installation doc has a note about that.

If I remember correctly, some other themes, on the other hand, aren't loaded from ~/.themes. So I'd recommend installing the theme under the default /usr, unless you have a particular reason.

actionless commented 3 years ago

and which apps ca'nt see the theme under ~/.themes/ ?

rudrab commented 3 years ago

@actionless as told in original post, pidgin is one such app.

actionless commented 3 years ago

are you sure you answering the same question which i asked?

nana-4 commented 3 years ago

@actionless At least budgie-desktop can't/couldn't. Maybe there are/were more, but I don't remember others :/

rudrab commented 3 years ago

are you sure you answering the same question which i asked?

@actionless no...i am sorry. Pidgin can actually see ~/.themes, not ~/.local/share/themes. Sorry for that.

actionless commented 3 years ago

hm, i see they wrote:

Mutter/GTK started to break ~/.themes some time a

would be interesting to know more

if that thing gonna broaden, we'll probably have to change in change_color.sh (or inside meson config itself?) to move gtk2 theme under ~/.themes and the rest under .local/share

actionless commented 3 years ago

btw, quite a low move (as usual :D) to change default theme location as soon as gtk2 development got officially frozen

actionless commented 3 years ago

btw, also gonna inter-link this here: https://github.com/themix-project/oomox-gtk-theme/issues/45

nana-4 commented 3 years ago

By default our meson installs the theme under /usr/share/themes, so this would be a change_color.sh specific issue :)

nana-4 commented 3 years ago

Personally I don't think it's great that some themes are in ~/.themes and others are in ~/.local/share/themes. Casual users would be confused, especially when uninstalling the themes.

IMO it would be the best to place all themes under /usr/share/themes, the safest theme location for every app. I'm not sure you'll agree with it as an Oomox author though.

actionless commented 3 years ago

themix have the code already for elevating permissions to write outside of /home/ (used for spotify theme)

but i think many of users wouldnt like if it will be un-alternatively writing to /usr/