fix: improved termiii notification service

nanahq / hydra

Nodejs Microservice web server for Nana App

https://api.trynanaapp.com

2 stars 0 forks source link

fix: improved termiii notification service #470

Closed siradji closed 2 months ago

siradji commented 2 months ago

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

siradji commented 2 months ago

@afkzoro , A minor improvements to your PR. please let's adhere to standards moving forward. With Types defs, proper return types. If you need clarify on return types speak up.