search

nand2mario / nestang

NESTang is an FPGA Nintendo Entertainment System implemented with Sipeed Tang Primer 25K, Nano 20K and Primer 20K boards
https://nand2mario.github.io/nestang
GNU General Public License v3.0
326 stars 36 forks source link

APU enhancement #79

Closed fjpolo closed 11 hours ago

fjpolo commented 1 month ago

[APU]

[VRC6]

[Mapper4/69]

References:

fjpolo commented 1 month ago

APU sounds broken in Little Sisyphus.nes if Enhancements are disabled, also with Celeste Mario.nes

Edit: found a few bugs that I need to fix

nand2mario commented 1 month ago

Can you remove the firmware here and add a separate PR for the firmware in the snestang repo? Let's keep the firmware in a single repo (snestang) for now and make sure the same firmware works for both nestang and snestang. CORE_ID can be used to determine which core is running. In the future we can set up a separate repo for the firmware.

fjpolo commented 1 month ago

Can you remove the firmware here and add a separate PR for the firmware in the snestang repo? Let's keep the firmware in a single repo (snestang) for now and make sure the same firmware works for both nestang and snestang. CORE_ID can be used to determine which core is running. In the future we can set up a separate repo for the firmware.

Will do, this way it will be cleaner. Adding a separate repo has the advantage of adding it as a submodule.

Edit: if you create an empty repo for the firmware, I can fork it, create a separate branch to add firmware/ as submodule and create a separate PR for it.

nikitalita commented 1 month ago

Does this implement the suggestions from this video? https://www.youtube.com/watch?v=8RrQrATnXXY&t=500s

fjpolo commented 1 month ago

Does this implement the suggestions from this video? https://www.youtube.com/watch?v=8RrQrATnXXY&t=500s

Oh yes, that's the idea! I watched that video a long time ago and yesterday came back to my mind.

I'm still on it though. I missunderstood how the module worked so I made some mistakes.

Will change the draft to a proper PR after fixing, testing, and removing firmware/ dir to have aclean PR

fjpolo commented 2 weeks ago

Results are sadly not as good as I'd like :( but at least enabling APU Enhancements gives the user a linear mixer, for those who'd prefer it :)

Edit: Slept on it and I think it's not ready yet. Will keep tinkering

fjpolo commented 2 weeks ago

After shifting Noise Channel output from 6bit to 8bit, it soudns better, at least for me.

fjpolo commented 1 week ago

It's finally working as expected. PR contains files from Cheats PR because I rebased form there

fjpolo commented 11 hours ago

Will be added in #88