search

nand2tetris / web-ide

A web-based IDE for https://nand2tetris.org
https://nand2tetris.github.io/web-ide
Other
38 stars 11 forks source link

Implement full topological sort #328

Closed netalondon closed 3 weeks ago

netalondon commented 1 month ago

@DavidSouther turns out we did need a proper topological sort. This is part of #327

netalondon commented 3 weeks ago

Let me know when this is rebased and the minimal test is in place.

I updated the test and now I believe it fails on main. Did I miss something?

DavidSouther commented 3 weeks ago

I opened #339 to keep the insertion sort, which I maintain is the neater and cleaner approach. But this PR was invaluable in tracking down a test case to make sure we got it right both here and for #327