nand2tetris / web-ide

A web-based IDE for https://nand2tetris.org
https://nand2tetris.github.io/web-ide
Other
84 stars 22 forks source link

[bug]: CPU Emulator doesn't handle symbols #501

Closed lyrakisk closed 2 days ago

lyrakisk commented 2 days ago

Tool

CPU Emulator

Interface

Website (https://nand2tetris.github.io/web-ide)

Contact Details

Please reply to this issue

What happened?

Note: this may be a missing feature instead of a bug. I'm not sure about the intended functionality of the CPU emulator.

The CPU emulator doesn't handle symbols. If I try to insert @SCREEN for example, it ignores my change and reverts back to @0.

This hasn't been an issue until chapter 6, but for testing chapter 7, it would be really useful if the CPU could also handle the symbols that the VM translator is producing.

Additional Comments

No response

Do you want to try to fix this bug?

Code of Conduct

lyrakisk commented 2 days ago

It looks like the CPU emulator does parse symbols, but only when loading a file. Since this emulator also needs to be stepped, I assume it makes sense that it can't use a symbol table. I'm therefore closing this issue.