search

nandorojo / burnt

Crunchy toasts for React Native. 🍞
MIT License
1.16k stars 36 forks source link

Support 5x version. #31

Open ivanvorobei opened 10 months ago

ivanvorobei commented 10 months ago

For new version added more styles. Good to integrate it as well. If need any help let me know I happy to assist.

nandorojo commented 10 months ago

Hey this would be great! I’d be happy to upgrade and support the new styles. Thanks for all the work on your libraries. Would you be open to submitting a PR for the Swift side? I can integrate any changes on the React Native side.

nandorojo commented 10 months ago

Also if you need any help on my end let me know and I can assist.

ivanvorobei commented 10 months ago

Sure. Let me know what you need and I ready to do or explain

nandorojo commented 10 months ago

The changes would be made in the ios folder in the source file and podspec. If you want to test the changes, you can go to example/ios and build the xcworkspace file. All changes will be reflected in the example.

nandorojo commented 5 months ago

Hey @ivanvorobei, any shot we could fix #39 on your library? Currently the text gets pretty cut off. Let me know if you need any suggestions. I think it should allow a wider toast for long text, as well as supporting multline text.

ivanvorobei commented 5 months ago

Hey @ivanvorobei, any shot we could fix #39 on your library? Currently the text gets pretty cut off. Let me know if you need any suggestions. I think it should allow a wider toast for long text, as well as supporting multline text.

Hi! I see developer put there so long text, but I think main concept is use there 1-2 words maximum. Maybe, I can do it optional, but with long text it looks ugly

nandorojo commented 5 months ago

Yeah, but I’m thinking it’s go to the developer.

Ideally you could set:

  1. maximum width (to let it be wider if you want, especially on iPad)
  2. A Boolean to let you show as many lines as you want
  3. Maybe edit how rounded the edges are (for multiple lines it should be rounded less)
ivanvorobei commented 5 months ago

In this case we missing native UI which apple did. Idea was mimicrate to original one

nandorojo commented 5 months ago

I see, yeah that's a fair point. I think many users of my library want a general Toast component which can also look like in-app notifications from apps like Instagram/Twitter. But I understand if that's not what you want for yours.

ivanvorobei commented 5 months ago

I see, yeah that's a fair point. I think many users of my library want a general Toast component which can also look like in-app notifications from apps like Instagram/Twitter. But I understand if that's not what you want for yours.

I think can add smth optional value for this case

nandorojo commented 5 months ago

Thank you!