search

nandorojo / burnt

Crunchy toasts for React Native. 🍞
MIT License
1.16k stars 36 forks source link

[Suggestion] IOS Alert Style for Android #35

Open AdzeB opened 8 months ago

AdzeB commented 8 months ago

Hey, I just wanted to put a suggestion out there: Could you implement the IOS Alert style for Android instead of using toast styles that come from the button? The suggestion has been implemented for Ting.

nandorojo commented 8 months ago

Yeah I’m open to it. Ting looks like a pretty big ripoff of Burnt without credit.

AdzeB commented 8 months ago

To be fair, He did state on the Reddit post(where I found the library) that the library takes inspiration from Burnt. He also refers to Burnt for Expo Users on the GitHub project.

nandorojo commented 8 months ago

Gotcha, I didn’t see the expo mention in the docs since it was a bit hidden. I’d expect it to be a bit more prominent on the docs and link back to Burnt since it’s using the same upstream libraries and essentially copying the API.

In any case, I’m curious what the best Android library is

AdzeB commented 8 months ago

Oh I see, are you still thinking of implementing devxoul/Toaster#appearance?

sidorchukandrew commented 2 months ago

I think a good choice would be to try porting over Material 3's snackbar. The Android docs seem to suggest that a snackbar would be better suited, especially since these are displayed in the foreground. @nandorojo Would it be helpful for me to create a PR?

nandorojo commented 2 months ago

yeah that should work as a step up from ToastAndroid

sidorchukandrew commented 1 month ago

I just found out that react-native-snackbar uses Google's native Snackbar component on Android (see here). Maybe the Android side here could pull that in.