search

nandorojo / burnt

Crunchy toasts for React Native. 🍞
MIT License
1.16k stars 36 forks source link

Adds action to web #38

Closed williamlmao closed 6 months ago

williamlmao commented 7 months ago

Sonner already supports action - adding parity on web.

williamlmao commented 6 months ago

hey @nandorojo - anything else you need from me here to get this merged?

nandorojo commented 6 months ago

I think you need to push your changes

williamlmao commented 6 months ago

Sorry - I might just not understand merging into someone else's repo from my forked repo well enough. I have a 2nd commit in this PR that adds the comment. Are you unable to see that on your end?

SCR-20240228-oufb
nandorojo commented 6 months ago

Oh, you didn’t put the comment in the right place. It should be where I left my review and in the same format as the other comments.

williamlmao commented 6 months ago

@nandorojo ohhh I'm sorry about that - got confused between the two files since the keys were the same keys. Just opened a PR with a cleaner commit https://github.com/nandorojo/burnt/pull/41